Skip to content

removed SpenderLeaf struct #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2021
Merged

removed SpenderLeaf struct #463

merged 2 commits into from
Dec 31, 2021

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Dec 16, 2021

No description provided.

@simzzz simzzz requested a review from elpiel December 16, 2021 16:34
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a few things to clarify left

total_spent: *total_spent,
//merkle_proof: [u8; 32], // TODO
});
let total_spent = new_state.balances.spenders.remove(&spender);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to remove() the entry?

@elpiel elpiel merged commit 1986c16 into aip-61-adex-v5 Dec 31, 2021
@elpiel elpiel linked an issue Jan 4, 2022 that may be closed by this pull request
2 tasks
@elpiel elpiel deleted the remove-spender-leaf branch January 4, 2022 10:18
@elpiel elpiel mentioned this pull request Jan 4, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SpenderLeaf
2 participants