Skip to content

Remove SpenderLeaf #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
elpiel opened this issue Oct 4, 2021 · 1 comment · Fixed by #463
Closed
2 tasks

Remove SpenderLeaf #442

elpiel opened this issue Oct 4, 2021 · 1 comment · Fixed by #463
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@elpiel
Copy link
Member

elpiel commented Oct 4, 2021

Part of #377
Instead of having a separate struct SpenderLeaf (due to ..... comment) we can directly put the total_spent in the Spender struct as an Option<UnifiedNum>

  • GET /v5/channel/:id/spender/:addr
  • GET /v5/channel/:id/spender/all
@elpiel elpiel added the enhancement New feature or request label Oct 4, 2021
@elpiel elpiel added this to the sentry-v0.2.0 milestone Oct 4, 2021
@elpiel elpiel linked a pull request Oct 4, 2021 that will close this issue
@elpiel elpiel removed a link to a pull request Oct 4, 2021
@simzzz simzzz self-assigned this Dec 16, 2021
@elpiel elpiel linked a pull request Jan 4, 2022 that will close this issue
@elpiel
Copy link
Member Author

elpiel commented Jan 4, 2022

Closed by #463

@elpiel elpiel closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants