Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

porting good first issue changes to v2 as well #2156

Merged
merged 2 commits into from
May 29, 2024
Merged

porting good first issue changes to v2 as well #2156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b24e93b
porting good first issue changes to v2 as well
May 24, 2024
e512298
snaps
May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...gration__/collect/__snapshots__/cli.zos-console.collect.response.integration.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ Invalid value specified for option:
You specified:
[email protected]

The value must match one of the following regular expressions:
The value must match one of the following options:
[ '^[a-zA-Z0-9]+$' ].

Example:
Expand Down
2 changes: 1 addition & 1 deletion ..._integration__/issue/__snapshots__/cli.zos-console.issue.command.integration.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ Invalid value specified for option:
You specified:
[email protected]

The value must match one of the following regular expressions:
The value must match one of the following regular options:
[ '^[a-zA-Z0-9]+$' ].

Example:
Expand Down
4 changes: 4 additions & 0 deletions packages/imperative/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to the Imperative package will be documented in this file.

## Recent Changes

- Patch: Modify error text in SyntaxValidator.invalidOptionError. [#2138](https://github.com/zowe/zowe-cli/issues/2138)

## `5.23.2`

- BugFix: Updated error text for invalid command options so that allowable values are displayed as strings instead of regular expressions when possible. [#1863](https://github.com/zowe/zowe-cli/issues/1863)
Expand Down
2 changes: 1 addition & 1 deletion packages/imperative/src/cmd/src/syntax/SyntaxValidator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ export class SyntaxValidator {
const msg: string = responseObject.console.error(
"Invalid value specified for option:\n{{long}} {{aliases}}\n\n" +
"You specified:\n{{optionVal}}\n\n" +
"The value must match one of the following regular expressions:\n{{allowed}}.",
"The value must match one of the following options:\n{{allowed}}.",
mustacheSummary);
this.appendValidatorError(responseObject,
{message: msg, optionInError: failingOption.name, definition: failingOption});
Expand Down
Loading