Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porting good first issue changes to v2 as well #2156

Merged
merged 2 commits into from
May 29, 2024
Merged

porting good first issue changes to v2 as well #2156

merged 2 commits into from
May 29, 2024

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented May 24, 2024

What It Does
see : Working through a good first issue #2149

Review Checklist
I certify that I have:

@ATorrise ATorrise linked an issue May 24, 2024 that may be closed by this pull request
@ATorrise ATorrise marked this pull request as ready for review May 24, 2024 18:45
@ATorrise ATorrise requested review from traeok, zFernand0, t1m0thyj and awharn and removed request for zFernand0 May 24, 2024 18:51
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (47ac4d6) to head (e512298).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2156   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         636      636           
  Lines       19046    19046           
  Branches     3947     4013   +66     
=======================================
  Hits        17358    17358           
  Misses       1687     1687           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the snapshot for packages/cli/__tests__/zosconsole/__integration__/issue/cli.zos-console.issue.command.integration.test.ts
image

Signed-off-by: Amber Torrise <[email protected]>
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ATorrise!

@ATorrise ATorrise merged commit 2a986a8 into master May 29, 2024
19 checks passed
@ATorrise ATorrise deleted the port-of-gfi branch May 29, 2024 15:14
@ATorrise ATorrise added the release-patch Indicates a patch to existing code has been applied label May 29, 2024
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Update CLI help text for invalid option error
3 participants