-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working through a good first issue #2149
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2149 +/- ##
==========================================
- Coverage 91.21% 91.20% -0.02%
==========================================
Files 628 628
Lines 17891 17891
Branches 3792 3755 -37
==========================================
- Hits 16319 16317 -2
- Misses 1571 1573 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
80f676a
to
1f79cfa
Compare
…ub.com> Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
1f79cfa
to
8894238
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ATorrise and @jace-roell!
I think we'll want to backport this change to master
branch for v2 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jace-roell and @ATorrise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Left a small question, but since this PR is against next
we don't have to address it here 😋
Signed-off-by: Amber Torrise <[email protected]>
Quality Gate passedIssues Measures |
Release failed for the
Check the workflow run for more error details. Powered by Octorelease 🚀 |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Corrects #2138
Review Checklist
I certify that I have: