Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working through a good first issue #2149

Merged
merged 7 commits into from
May 24, 2024
Merged

Conversation

ATorrise
Copy link
Contributor

What It Does
Corrects #2138

Review Checklist
I certify that I have:

@ATorrise ATorrise linked an issue May 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (5ef1aeb) to head (a67482c).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2149      +/-   ##
==========================================
- Coverage   91.21%   91.20%   -0.02%     
==========================================
  Files         628      628              
  Lines       17891    17891              
  Branches     3792     3755      -37     
==========================================
- Hits        16319    16317       -2     
- Misses       1571     1573       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zFernand0 zFernand0 assigned anaxceron and unassigned ATorrise May 22, 2024
@ATorrise ATorrise assigned jace-roell and unassigned anaxceron May 22, 2024
@ATorrise ATorrise marked this pull request as ready for review May 22, 2024 15:39
@ATorrise ATorrise force-pushed the error-message-modification branch from 80f676a to 1f79cfa Compare May 22, 2024 15:52
Amber Torrise added 3 commits May 22, 2024 11:54
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise force-pushed the error-message-modification branch from 1f79cfa to 8894238 Compare May 22, 2024 15:55
@t1m0thyj t1m0thyj requested a review from anaxceron May 23, 2024 13:14
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ATorrise and @jace-roell!

I think we'll want to backport this change to master branch for v2 🙂

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jace-roell and @ATorrise!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Left a small question, but since this PR is against next we don't have to address it here 😋

packages/imperative/CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise added the release-patch Indicates a patch to existing code has been applied label May 23, 2024
@ATorrise ATorrise removed the release-patch Indicates a patch to existing code has been applied label May 23, 2024
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ATorrise ATorrise merged commit f4b600b into next May 24, 2024
42 checks passed
@ATorrise ATorrise deleted the error-message-modification branch May 24, 2024 14:46
@ATorrise ATorrise added the release-patch Indicates a patch to existing code has been applied label May 24, 2024
@t1m0thyj t1m0thyj removed the release-patch Indicates a patch to existing code has been applied label May 24, 2024
Copy link

Release failed for the next branch. 😢

Error: The process '/opt/hostedtoolcache/node/20.13.1/x64/bin/npm' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/npm.js:974:21)
    at ExecState.CheckComplete (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/npm.js:960:16)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/npm.js:863:21)
    at ChildProcess.emit (node:events:514:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

Check the workflow run for more error details.

Powered by Octorelease 🚀

Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Update CLI help text for invalid option error
6 participants