feat(ble): Allow disabling BLE BAS reporting #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The battery reporting has been known to cause macOS computers to wakeup repeatedly. In some cases (e.g. display or custom lighting implementation) one might want to collect battery SOC without broadcasting over BLE
|
I also experience this, is there any clue why this happens? |
caksoylar
reviewed
Oct 20, 2023
There was a problem hiding this comment.
Can you also add CONFIG_BT_BAS to the table in https://zmk.dev/docs/config/system#bluetooth? Even though it isn't defined by ZMK, we seem to document them there if it can be useful to the user.
Co-authored-by: Cem Aksoylar <[email protected]>
…l/zmk into battery-report-ble-config-2
caksoylar
reviewed
Oct 20, 2023
Co-authored-by: Cem Aksoylar <[email protected]>
joelspadin
reviewed
Nov 3, 2023
|
@ReFil Can you please rebase so this can be merged. Code looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The battery reporting has been known to cause macOS computers to wakeup repeatedly. In some cases (e.g. display or custom lighting implementation) one might want to collect battery SOC without broadcasting over BLE