feat(ble): Only update BAS when active #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
requested changes
Nov 16, 2023
ReFil
force-pushed
the
bas-update-active
branch
from
1b2e214 to
e3f8010
Compare
caksoylar
added
enhancement
petejohanson
requested changes
Nov 24, 2023
Subscribes to the activity changing event, will stop the battery work timer when in idle or deep sleep, restart when board goes active
ReFil
force-pushed
the
bas-update-active
branch
from
e3f8010 to
233c4f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a further mitigation against spurious wakeups (in addition to #1973) without having to disable the battery service entirely, the battery percentage can only be updated when the board is active i.e. when in use, which infers the computer is also in use