Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 优化了绩点计算器在计算状态下课程按钮的显示 #179

Merged
merged 4 commits into from
Jan 20, 2025
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/pages/score/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
<w-collapse v-if="!isEdit" class="score-list-collapse">
<w-collapse-panel
v-for="item in selectedLessonsList"
:key="item.lessonID"
:key="item.className"
arrow
:selected="false"
>
Expand Down Expand Up @@ -109,7 +109,7 @@

<w-collapse-panel
v-for="item in unSelectedLessonsList"
:key="item.lessonID"
:key="item.className"
Copy link
Collaborator

@j10ccc j10ccc Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里没有写明白。对于大学这么多节体育课,他们的 lessonID 都是一样的,并且 lessonName 也一样。你选了 className 作为 key,大部分场景下体育课确实不一样,但不保证有人两个学期都选了同一天的,同老师的体育课,className 还是会相同。根本原因就是 key 不唯一。

key 最好是 submitTimelessonID 组成,前者大概率保证唯一性,后者是拿 ID 字段让代码更可读。

代码里面顺便加个注释吧,把这个 key 的取值讲清楚

arrow
:selected="true"
>
Expand Down Expand Up @@ -141,7 +141,7 @@
</w-collapse-panel>
</w-collapse>

<w-button v-if="isEdit" class="lesson-group-btn" @tap="requireLessonChange()">
<w-button v-if="isEdit && requiredScoreList.length != 0" class="lesson-group-btn" @tap="requireLessonChange()">
必修课
</w-button>
<w-collapse v-if="isEdit" class="score-list-collapse">
Expand All @@ -166,7 +166,7 @@
</w-panel>
</w-collapse>

<w-button v-if="isEdit" class="lesson-group-btn" @tap="limitedLessonChange()">
<w-button v-if="isEdit && limitedScoreList.length != 0" class="lesson-group-btn" @tap="limitedLessonChange()">
限选课
</w-button>
<w-collapse v-if="isEdit" class="score-list-collapse">
Expand Down Expand Up @@ -204,7 +204,7 @@
</w-panel>
</w-collapse>

<w-button v-if="isEdit" class="lesson-group-btn" @tap="electiveLessonChange()">
<w-button v-if="isEdit && electiveScoreList.length != 0" class="lesson-group-btn" @tap="electiveLessonChange()">
任选课
</w-button>
<w-collapse v-if="isEdit" class="score-list-collapse">
Expand Down Expand Up @@ -242,7 +242,7 @@
</w-panel>
</w-collapse>

<w-button v-if="isEdit" class="lesson-group-btn" @tap="optionalLessonChange()">
<w-button v-if="isEdit && optionalScoreList.length != 0" class="lesson-group-btn" @tap="optionalLessonChange()">
选修课
</w-button>
<w-collapse v-if="isEdit" class="score-list-collapse">
Expand Down Expand Up @@ -280,7 +280,7 @@
</w-panel>
</w-collapse>

<w-button v-if="isEdit" class="lesson-group-btn" @tap="sportsLessonChange()">
<w-button v-if="isEdit && sportsScoreList.length != 0" class="lesson-group-btn" @tap="sportsLessonChange()">
体育课
</w-button>
<w-collapse v-if="isEdit" class="score-list-collapse">
Expand Down
Loading