fix: 优化了绩点计算器在计算状态下课程按钮的显示 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j10ccc
requested changes
Jan 20, 2025
src/pages/score/index.vue
Outdated
| @@ -109,7 +109,7 @@ | |||
|
|
|||
| <w-collapse-panel | |||
| v-for="item in unSelectedLessonsList" | |||
| :key="item.lessonID" | |||
| :key="item.className" | |||
There was a problem hiding this comment.
这里没有写明白。对于大学这么多节体育课，他们的 lessonID 都是一样的，并且 lessonName 也一样。你选了 className 作为 key，大部分场景下体育课确实不一样，但不保证有人两个学期都选了同一天的，同老师的体育课，className 还是会相同。根本原因就是 key 不唯一。
key 最好是 submitTime 和 lessonID 组成，前者大概率保证唯一性，后者是拿 ID 字段让代码更可读。
代码里面顺便加个注释吧，把这个 key 的取值讲清楚
j10ccc
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.