Zingo sync scan transaction #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oscar-Pepper
requested review from
zancas,
AloeareV,
fluidvanadium and
idky137
Merged
fluidvanadium
previously requested changes
Aug 21, 2024
|
I pushed a resolution of merge conflicts with latest dev. |
…of get_wallet_block calls
zancas
force-pushed
the
zingo_sync_scan_transaction
branch
from
92691a6
to
378081e
Compare
zancas
previously approved these changes
Nov 12, 2024
zancas
dismissed
fluidvanadium’s stale review
Some edits added, this comment is non-blocking.
zancas
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
This PR is the first part of a new feature. The zingo-sync feature is not yet integrated into the codebase, so it's safe to merge this code into dev. Review has shown some interesting directions we might take, but we know there's more code to review in subsequent PRs, which are also chunks of the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ontop of #1328