Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zingo sync parse memos #1334

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Conversation

Oscar-Pepper
Copy link
Contributor

ontop of #1331

@Oscar-Pepper Oscar-Pepper marked this pull request as ready for review August 21, 2024 12:16
@zancas zancas added the sync label Sep 7, 2024
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of the code does not properly handle zingo-memo::ParsedMemo::Version1. We'll need to fully test and handle that before this feature can get into production.

@zancas
Copy link
Member

zancas commented Nov 12, 2024

I am concerned about dependent PRs not being landable because of this, so I am landing it with a todo which is to upgrade to modern memo handling.

@zancas zancas merged commit a1d1166 into zingolabs:dev Nov 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants