Persist state #136
Merged
Persist state #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WULCAN
requested changes
Oct 19, 2024
Normally, Node modules are only loaded once which makes module variables just as persistent as a globalThis property. With hot-loading, it isn't safe to store the old implementation's instance anyway. For Lyra in dev moce, reinitializing seems OK to me, especially with the disk persisted state.
Testing reveals that Next does something fishy. It seems server actions use a separate module tree in development mode.
With webapp/store.json in the root gitignore, prettier fails to ignore, possibly because it evaluates the patterns relative to its working dir.
WULCAN
reviewed
Oct 19, 2024
Conflicts: webapp/src/actions/updateTranslation.ts webapp/src/dataAccess.ts
WULCAN
reviewed
Oct 19, 2024
WULCAN
reviewed
Oct 26, 2024
amerharb
reviewed
Nov 24, 2024
amerharb
approved these changes
Nov 24, 2024
WULCAN
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to resolve #30.
This contained a known bug:
When there are multiple projects, the state from store.json doesn't get loaded into all projects if the user only interacts with one of them. This means that data can get lost, if a user updates one project without first visiting all projects.
6ac5ceb tries to fix the bug