Update libraries and adjust code to match again #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I'm going to add an additional commit to this to support open-ead/nnheaders#32 |
ThePixelGamer
commented
Aug 28, 2024
There was a problem hiding this comment.
Reviewed 152 of 157 files at r2.
Reviewable status: 152 of 165 files reviewed, all discussions resolved
|
@leoetlino could you review this when you have a chance? I went ahead and reviewed the files that just change the include path |
leoetlino
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
thanks, much appreciated!
Reviewed 8 of 10 files at r1, 157 of 157 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ThePixelGamer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to update the libraries and discovered there were some mismatches due to MathCalcCommon changes earlier this year. This pr fixes those
This change is