ZeekPlugin: Make non-sufficient minimum version a FATAL_ERROR #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelzel
force-pushed
the
topic/awelzel/minimum-version-fatal-error
branch
from
5367d93
to
586cb31
Compare
The warning is useful, but usually scrolls off the screen before users run into errors that are less actionable. We now had 3 reports of users that were stuck with less useful message around the IN_LIST operator when all they had to do was but the cmake_minimum_required() line.
bbannier
approved these changes
Oct 9, 2023
awelzel
force-pushed
the
topic/awelzel/minimum-version-fatal-error
branch
from
586cb31
to
7832341
Compare
|
Fully agree with the change. I've added this to the 6.1 board for visibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning is useful, but usually scrolls off the screen before users
run into errors that are less actionable. We now had 3 reports of users
that were stuck with less useful message around the IN_LIST operator
when all they had to do was but the cmake_minimum_required() line.