Skip to content

Commit

Permalink
ZeekPlugin: Make non-sufficient minimum version a FATAL_ERROR
Browse files Browse the repository at this point in the history
The warning is useful, but usually scrolls of the screen before running
into errors that are less useful. We now had 3 reports of users that were
stuck with the less useful message around the IN_LIST operator.
  • Loading branch information
awelzel committed Oct 9, 2023
1 parent 164243f commit 5367d93
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ZeekPlugin.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ include(ZeekPluginDynamic)

if (NOT ZEEK_PLUGIN_INTERNAL_BUILD AND ${CMAKE_MINIMUM_REQUIRED_VERSION} VERSION_LESS 3.15.0)
message(
WARNING
"Package requires CMake ${CMAKE_MINIMUM_REQUIRED_VERSION} which is less than Zeek's requirement (3.15.0). This will likely cause build failures and should be fixed."
FATAL_ERROR
"The plugin requires CMake ${CMAKE_MINIMUM_REQUIRED_VERSION} which is less than Zeek's requirement (3.15.0). Please update cmake_minimum_required VERSION to 3.15 or higher."
)
endif ()

Expand Down

0 comments on commit 5367d93

Please sign in to comment.