Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spicy_add_analyzer: Discourage SCRIPTS usage #114

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions ZeekSpicyAnalyzerSupport.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ include(GNUInstallDirs)
# NAME <analyzer_name>
# [SOURCES <source files for spicyz>...]
# [PACKAGE_NAME <package_name>]
# [SCRIPTS <additional script files to install>...]
# [CXX_LINK <libraries to link>...]
# [ENV <environment variable=value>...]
# )
Expand Down Expand Up @@ -72,14 +71,10 @@ function (spicy_add_analyzer)
install(FILES ${OUTPUT} DESTINATION "${SPICY_MODULE_OUTPUT_DIR_INSTALL}")
endif ()

if (SPICY_SCRIPTS_OUTPUT_DIR_INSTALL AND DEFINED SPICY_ANALYZER_SCRIPTS)
if (NOT DEFINED SPICY_ANALYZER_PACKAGE_NAME)
message(FATAL_ERROR "SCRIPTS argument requires PACKAGE_NAME")
endif ()
install(
FILES ${SPICY_ANALYZER_SCRIPTS}
DESTINATION
"${SPICY_SCRIPTS_OUTPUT_DIR_INSTALL}/${SPICY_ANALYZER_PACKAGE_NAME}/${NAME_LOWER}")
if (DEFINED SPICY_ANALYZER_SCRIPTS)
message(WARNING "The SCRIPTS argument for spicy_add_analyzer() has "
"been non-functional. Please install extra Zeek scripts "
"using zkg or site-specific mechanisms.")
endif ()

get_property(tmp GLOBAL PROPERTY __spicy_included_analyzers)
Expand Down
Loading