spicy_add_analyzer: Discourage SCRIPTS usage

[awelzel]

The SCRIPTS parameter hasn't been functional for a long time and it hasn't been obvious where exactly to install these scripts. They aren't directly comparable to classic plugin's scripts as a Spicy analyzer doesn't have its own directory.

For now, punt on a decision and reference zkg through a warning to keep expectations low and avoid surprises that SCRIPTS isn't working.

[awelzel]

@rsmmr - this feels a bit lazy and @bbannier suggested the explicit SCRIPTS could actually be nice, but seems the non-working situation and the fact that zkg should/can manage this might be "good for now".

[rsmmr]

I do think we need some kind of solution here that allows people to install scripts via cmake. Practically all analyzers come with scripts, and just not installing them isn't very useful. While zkg is one way out, we do still allow "make install" for the analyzer itself; the CMake has explicit install() commands for that. Not offering that for the scripts doesn't feel very helpful to me. If it's via SCRIPTS or some install_scripts() function doesn't really matter I think. The catch of course is finding the right destination for the installed scripts, not really sure about that myself.

[awelzel]

If it's via SCRIPTS or some install_scripts() function doesn't really matter I think. The catch of course is finding the right destination for the installed scripts, not really sure about that myself.

As mentioned in the ticket - with install_scripts() my thought was that share/zeek or share/zeek/site/ could be the base, but the concrete path left to the plugin/analyzer developer. But that's rather unhelpful and likely to result in inconsistencies it's not even worth providing - SCRIPTS could be more opinionated.

@ckreibich - any thoughts here? We could shelve #97 for 7.1, too?

[awelzel]

@ckreibich - any thoughts here? We could shelve #97 for 7.1, too?

I am closing this. Nothing for 7.0 at this point.