Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Strapping Pins before Flashing P0 #237

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Check Strapping Pins before Flashing P0 #237

merged 5 commits into from
Dec 16, 2024

Conversation

LukasBaecker
Copy link
Contributor

@LukasBaecker LukasBaecker commented Dec 11, 2024

In [Lizard's PR #95] (zauberzeug/lizard#95) a check of the pins that could block the flashing was implemented.

This PR added a check and notifications for the UI to warn the user if flashing cannot be performed.

  • Move EspPins to Robotbrain so that they are accessible
  • get_pin_value function for a single Esp pin
  • Function to check the status of p0 strapping pins
  • Prevent flashing when strapping pin is high

@LukasBaecker LukasBaecker marked this pull request as ready for review December 11, 2024 15:12
@falkoschindler falkoschindler added the enhancement New feature or request label Dec 12, 2024
@falkoschindler falkoschindler added this to the 0.21.0 milestone Dec 12, 2024
@pascalzauberzeug
Copy link
Contributor

Just tested it on our robot 👍

@pascalzauberzeug pascalzauberzeug merged commit 5d55fb4 into main Dec 16, 2024
6 checks passed
@pascalzauberzeug pascalzauberzeug deleted the esp_pins branch December 16, 2024 16:15
pascalzauberzeug added a commit to zauberzeug/field_friend that referenced this pull request Dec 19, 2024
In [rosys PR #237](zauberzeug/rosys#237) the
EspPins for Core and P0 are created in rosys/hardware/robot_brain.py.
This PR changes the import of the EspPins according to this change.

---------

Co-authored-by: Pascal Schade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants