feature: io package inspect stream reader #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuecs
added
the
major
szuecs
force-pushed
the
feature/inspect-stream-reader
branch
from
df50aa6
to
2b0527a
Compare
refactor: block* filters to use the new io package refactor: remove custom matcher Signed-off-by: Sandor Szücs <[email protected]>
szuecs
force-pushed
the
feature/inspect-stream-reader
branch
from
443473c
to
4425ef7
Compare
|
|
||
| var ( | ||
| ErrClosed = errors.New("reader closed") | ||
| "github.com/zalando/skipper/io" |
There was a problem hiding this comment.
I'd still use skpio here
|
👍 |
1 similar comment
|
👍 |
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: io package inspect stream reader
refactor: block* filters to use the new io package
last step to replace #2428