Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockContent with body size much bigger than matcher buffer returns 500 #2655

Closed
szuecs opened this issue Oct 6, 2023 · 1 comment
Closed
Labels
bugfix Bug fixes and patches

Comments

@szuecs
Copy link
Member

szuecs commented Oct 6, 2023

Describe the bug

a bit similar to #2605

To Reproduce

% ./bin/skipper -inline-routes='r: * -> status(200) -> inlineContent("OK") -> <shunt>' -address :9001 &
[APP]ERRO[0007] error while discarding remainder request body: unexpected EOF.
127.0.0.1 - - [06/Oct/2023:11:13:07 +0200] "POST /foo HTTP/1.1" 499 2 "-" "curl/7.49.0" 1 127.0.0.1:9001 - -

% ./bin/skipper -max-matcher-buffer-size 100 -inline-routes='r: * -> blockContent("request") -> "http://127.0.0.1:9001";' &
[APP]ERRO[0005] error while proxying after 1.687247ms, route r with backend network http://127.0.0.1:9001, status code 500: dialing failed false: unexpected error from Go stdlib net/http package during roundtrip: net/http: HTTP/1.x transport connection broken: http: ContentLength=100003 with Body length 0, remote host: 127.0.0.1, request: "POST /foo HTTP/1.1", host: 127.0.0.1:9090, user agent: "curl/7.49.0"

% curl -d $(ruby -e 'print ("A"*100000)+"ret"') http://127.0.0.1:9090/foo
Internal Server Error

Expected behavior

Client should get the 200 OK instead

Observed behavior

Client got 500 Internal Server Error

@szuecs szuecs added the bugfix Bug fixes and patches label Oct 6, 2023
@szuecs
Copy link
Member Author

szuecs commented Jan 23, 2024

After #2828 I can not reproduce it anymore. Doubling the input returns zsh: argument list too long: curl

@szuecs szuecs closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes and patches
Projects
None yet
Development

No branches or pull requests

1 participant