validator: ensure no network backend path

cmd/webhook/admission/admission_test.go

@@ -136,7 +136,7 @@ func TestRouteGroupAdmitter(t *testing.T) {
 		{
 			name:      "routegroup with invalid backends",
 			inputFile: "rg-with-invalid-backend-path.json",
-			message:   `backend address \"http://example.com/foo\" contains path\nbackend address \"http://example.com/foo/bar\" contains path\nbackend address \"http://example.com/foo/\" contains path\nbackend address \"/foo\" contains path\nbackend address \"http://example.com/\" contains path\nbackend address \"example.com/\" contains path\nbackend address \"example.com/foo\" contains path`,
+			message:   `backend address \"http://example.com/foo\" contains path\nbackend address \"http://example.com/foo/bar\" contains path\nbackend address \"http://example.com/foo/\" contains path\nbackend address \"/foo\" contains path\nbackend address \"http://example.com/\" contains path\nbackend address \"example.com/\" contains path\nbackend address \"example.com/foo\" contains path\nbackend address \"http://example.com?foo=bar\" contains path`,
 		},
 	} {
 		t.Run(tc.name, func(t *testing.T) {

cmd/webhook/admission/testdata/rg/rg-with-invalid-backend-path.json

@@ -64,6 +64,11 @@
             "name" : "invalid-backend8",
             "type" : "network",
             "address" : "example.com/foo"
+          },
+          {
+            "name" : "invalid-backend9",
+            "type" : "network",
+            "address" : "http://example.com?foo=bar"
           }
         ],
         "defaultBackends": [

dataclients/kubernetes/definitions/routegroupvalidator.go

@@ -99,7 +99,7 @@ func (rgv *RouteGroupValidator) validateBackends(item *RouteGroupItem) error {
 		address, err := url.Parse(backend.Address)
 		if err != nil {
 			errs = append(errs, fmt.Errorf("failed to parse backend address %q: %w", backend.Address, err))
-		} else if address.Path != "" {
+		} else if address.Path != "" || address.RawQuery != "" {
 			errs = append(errs, fmt.Errorf("backend address %q contains path", backend.Address))
 		}
 	}

dataclients/kubernetes/definitions/testdata/errorwrapdata/errors.log

@@ -9,3 +9,4 @@ backend address "http://example.com/foo/bar" contains path
 backend address "http://example.com/foo/" contains path
 backend address "/foo" contains path
 backend address "example.com/" contains path
+backend address "http://example.com?foo=bar" contains path

dataclients/kubernetes/definitions/testdata/errorwrapdata/routegroups.json

@@ -178,6 +178,11 @@
                         "type": "network",
                         "address": "http://user:[email protected]"
                     },
+                    {
+                        "name": "backend8",
+                        "type": "network",
+                        "address": "http://example.com?foo=bar"
+                    },
                     {
                         "name": "shunt",
                         "type": "shunt"

dataclients/kubernetes/definitions/testdata/validation/route-with-invalid-backend-with-path.log

@@ -4,3 +4,4 @@ backend address \\\"/foo\\\" contains path
 backend address \\\"/foo/bar\\\" contains path
 backend address \\\"example\.com/foo\\\" contains path
 backend address \\\"http://example\.com/\\\" contains path
+backend address \\\"http://example\.com\?foo=bar\\\" contains path

dataclients/kubernetes/definitions/testdata/validation/route-with-invalid-backend-with-path.yaml

@@ -34,6 +34,9 @@ spec:
   - name: backend8
     type: network
     address: http://user:[email protected]
+  - name: backend9
+    type: network
+    address: http://example.com?foo=bar
   defaultBackends:
   - backendName: app
   routes: