validator: ensure no network backend path #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaSaber
commented
Nov 6, 2023
dataclients/kubernetes/definitions/testdata/validation/route-with-invalid-backend-with-path.log
Outdated
Show resolved
Hide resolved
Signed-off-by: Mustafa Abdelrahman <[email protected]>
MustafaSaber
force-pushed
the
validate-backend-path
branch
from
2ada4c9
to
f0483b1
Compare
dataclients/kubernetes/definitions/testdata/errorwrapdata/errors.log
Outdated
Show resolved
Hide resolved
dataclients/kubernetes/definitions/testdata/validation/route-with-invalid-backend-with-path.log
Outdated
Show resolved
Hide resolved
dataclients/kubernetes/definitions/testdata/validation/route-with-multiple-filters-one-item.log
Outdated
Show resolved
Hide resolved
dataclients/kubernetes/definitions/testdata/validation/route-with-multiple-filters-one-item.log
Outdated
Show resolved
Hide resolved
Signed-off-by: Mustafa Abdelrahman <[email protected]>
MustafaSaber
commented
Nov 7, 2023
| @@ -1 +1 @@ | |||
| single filter expected | |||
| single filter expected at \\\"foo\(42\) -> bar\(24\)\\\" | |||
There was a problem hiding this comment.
Not related to the change but makes this test case more robust.
MustafaSaber
commented
Nov 7, 2023
| @@ -1 +1 @@ | |||
| single predicate expected | |||
| single predicate expected at \\\"Foo\(\\\\\\"X-Bar\\\\\\", \\\\\\"42\\\\\\"\) && Bar\(\\\\\\"X-Foo\\\\\\", \\\\\\"24\\\\\\"\)\\\" | |||
There was a problem hiding this comment.
Not related to the change but makes this test case more robust.
szuecs
reviewed
Nov 7, 2023
szuecs
reviewed
Nov 7, 2023
|
👍 |
Signed-off-by: Mustafa Abdelrahman <[email protected]>
szuecs
reviewed
Nov 8, 2023
Signed-off-by: Mustafa Abdelrahman <[email protected]>
Signed-off-by: Mustafa Abdelrahman <[email protected]>
Signed-off-by: Mustafa Abdelrahman <[email protected]>
|
👍 |
Comment on lines
136
to
140
| { | ||
| name: "routegroup with invalid backends", | ||
| inputFile: "rg-with-invalid-backend-path.json", | ||
| message: `backend address \"http://example.com/foo\" contains path or query\nbackend address \"http://example.com/foo/bar\" contains path or query\nbackend address \"http://example.com/foo/\" contains path or query\nbackend address \"/foo\" contains path or query\nbackend address \"http://example.com/\" contains path or query\nbackend address \"example.com/\" contains path or query\nbackend address \"example.com/foo\" contains path or query\nbackend address \"http://example.com?foo=bar\" contains path or query`, | ||
| }, |
There was a problem hiding this comment.
Do we need an essentially copy-pasted test case for the webhook given that it relies on the dataclients Validator that has its own test?
There was a problem hiding this comment.
If both validators have the same options then no, but maybe webhook has more strict way of validation later. Also this tests webhook response, so the error maybe the same but the response is different.
|
👍 |
…sure we only validate network backends. Signed-off-by: Mustafa Abdelrahman <[email protected]>
|
👍 |
|
👍 |
MustafaSaber
changed the title
MustafaSaber
changed the title
AlexanderYastrebov
pushed a commit
that referenced
this pull request
Nov 27, 2023
Validate that network backends doesn't have paths Include query params into validation Include missing scheme, rename functions for consistant naming and ensure we only validate network backends. Signed-off-by: Mustafa Abdelrahman <[email protected]>
AlexanderYastrebov
pushed a commit
that referenced
this pull request
Nov 27, 2023
Validate that network backends doesn't have paths Include query params into validation Include missing scheme, rename functions for consistant naming and ensure we only validate network backends. Signed-off-by: Mustafa Abdelrahman <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Dec 6, 2023
…at in the error message Followup on #2719 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Dec 6, 2023
…at in the error message Followup on #2719 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Dec 6, 2023
…at in the error message (#2778) Followup on #2719 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Dec 6, 2023
Disable address validation to prevent errors for existing RouteGroups. Reverts #2719 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Dec 6, 2023
Disable address validation to prevent errors for existing RouteGroups. Reverts #2719 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Dec 6, 2023
Disable address validation to prevent errors for existing RouteGroups. Reverts #2719 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Dec 6, 2023
…2780) Disable address validation to prevent errors for existing RouteGroups. Reverts #2719 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that network backends doesn't include paths.