-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kobuki Gazebo Updates. #34
Conversation
@bit-pirate Can you review this PR? |
I can and will, but after IFA. |
@bit-pirate bump |
#include <boost/bind.hpp> | ||
#include <sensor_msgs/JointState.h> | ||
#include <tf/LinearMath/Quaternion.h> | ||
#include <gazebo/math/gzmath.hh> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the headers align with the code style guide. For reference: http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes
I have applied your suggestions. And created a new issue to follow-up licensing. |
PR looks fine. However, I'm unable to test it. When I checkout this branch I get this warning and error:
Do I need any other updates to make this work? PS: I using |
empty_world and play_ground with randomwalker app work fine in my pc. Does it happen every time? with clean compilation? |
I have updated my workspace sources (using indigo branches) and my ROS debs Do you have any commits/PRs pending for other repos? This error says it's missing a parameter for the namespace. Where does this On 18 September 2014 09:49, Jihoon Lee [email protected] wrote:
Innovation Team Leader |
So, the issue was the slow loading online gazebo models. Now it's working fine. PR tested and verified. |
It utilise GazeboRos Utilities for tf prefix and topic namespacing.
Referenced GazeboRosDiffDrive.
Also now it has
base_prefix
parameter to configure mobile base namespace. So now we can use topics in following way.odom
tf
joint_state
<base_prefix>/commands/velocity
<base_prefix>/sensors/xxx
<base_prefix>/events/xxx