Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kobuki Gazebo Updates. #34

Merged
merged 3 commits into from
Sep 19, 2014
Merged

Kobuki Gazebo Updates. #34

merged 3 commits into from
Sep 19, 2014

Conversation

jihoonl
Copy link
Collaborator

@jihoonl jihoonl commented Aug 25, 2014

It utilise GazeboRos Utilities for tf prefix and topic namespacing.

Referenced GazeboRosDiffDrive.

Also now it has base_prefix parameter to configure mobile base namespace. So now we can use topics in following way.

odom
tf
joint_state
<base_prefix>/commands/velocity
<base_prefix>/sensors/xxx
<base_prefix>/events/xxx

@jihoonl
Copy link
Collaborator Author

jihoonl commented Aug 25, 2014

@bit-pirate Can you review this PR?

@bit-pirate
Copy link
Contributor

I can and will, but after IFA.

@jihoonl
Copy link
Collaborator Author

jihoonl commented Sep 16, 2014

@bit-pirate bump

#include <boost/bind.hpp>
#include <sensor_msgs/JointState.h>
#include <tf/LinearMath/Quaternion.h>
#include <gazebo/math/gzmath.hh>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the headers align with the code style guide. For reference: http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes

@jihoonl
Copy link
Collaborator Author

jihoonl commented Sep 16, 2014

I have applied your suggestions. And created a new issue to follow-up licensing.
Please don't mix up the PR with different issue.

@bit-pirate
Copy link
Contributor

PR looks fine. However, I'm unable to test it. When I checkout this branch I get this warning and error:

Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Error [gazebo.cc:220] Waited 11 seconds for namespaces. Giving up.
Error [Node.cc:90] No namespace found

Do I need any other updates to make this work?

PS: I using roslaunch kobuki_gazebo kobuki_empty_world.launch for testing.

@jihoonl
Copy link
Collaborator Author

jihoonl commented Sep 18, 2014

empty_world and play_ground with randomwalker app work fine in my pc.

Does it happen every time? with clean compilation?

@bit-pirate
Copy link
Contributor

I have updated my workspace sources (using indigo branches) and my ROS debs
are also up to date.

Do you have any commits/PRs pending for other repos?

This error says it's missing a parameter for the namespace. Where does this
need to be defined?

On 18 September 2014 09:49, Jihoon Lee [email protected] wrote:

empty_world and play_ground with randomwalker app work fine in my pc.

Does it happen every time? with clean compilation?


Reply to this email directly or view it on GitHub
#34 (comment)
.

Innovation Team Leader
Yujin Robot
Seoul, Republic of Korea
Twitter: @yujinrobotinno
Website: http://inno.yujinrobot.com
Email: [email protected]
Phone: +82-70-46577073

@bit-pirate
Copy link
Contributor

So, the issue was the slow loading online gazebo models. Now it's working fine. PR tested and verified.

bit-pirate pushed a commit that referenced this pull request Sep 19, 2014
@bit-pirate bit-pirate merged commit 09ff672 into indigo Sep 19, 2014
@bit-pirate bit-pirate deleted the kobuki_gazebo_updates branch September 19, 2014 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants