DEP: move dev-only dependencies to requirements files #4983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
dep/move_dev-only_deps_to_requirement_files
branch
from
469e2e0
to
c4d8040
Compare
neutrinoceros
added
infrastructure
neutrinoceros
force-pushed
the
dep/move_dev-only_deps_to_requirement_files
branch
from
c4d8040
to
97a5fbf
Compare
|
Should update the instructions on building the docs too. This line: |
neutrinoceros
force-pushed
the
dep/move_dev-only_deps_to_requirement_files
branch
from
97a5fbf
to
435e624
Compare
|
Good catch. Done ! |
oh, that did make the docs build fail though... |
|
Yes that's expected since the installation script used there is out of my control. |
|
@yt-fido test this please. |
neutrinoceros
force-pushed
the
dep/move_dev-only_deps_to_requirement_files
branch
from
435e624
to
621c71a
Compare
neutrinoceros
force-pushed
the
dep/move_dev-only_deps_to_requirement_files
branch
from
621c71a
to
5ad93c4
Compare
chrishavlin
previously approved these changes
Sep 11, 2024
There was a problem hiding this comment.
LGTM
but one other docs note: https://yt-project.org/docs/dev/developing/testing.html#handling-yt-dependencies was out of date even before this PR :) if you feel like editing here that'd be great but I'm also OK with just opening an issue to track the need to update that page.
|
Thanks for pointing it out. Since the |
|
btw thanks @Xarthisius for your work on Jenkins, I'm glad this is working ! |
chrishavlin
approved these changes
Sep 11, 2024
Xarthisius
approved these changes
Sep 11, 2024
neutrinoceros
deleted the
dep/move_dev-only_deps_to_requirement_files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Close #4976
TODO: