-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: linspace
and logspace
give incorrect results or crash with some inputs
#544
Conversation
pre-commit.ci autofix |
2 similar comments
pre-commit.ci autofix |
pre-commit.ci autofix |
Thank you so much for catching and fixing so many (of my) mistakes ! There's a merge conflict now that prevents merging, can you please update your branch with a rebase ? |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
d12240e
to
07082a8
Compare
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
I think that should address all of your review points, but let me know if there are any follow-ups or anything else. And no problem for catching these bugs - I'm working on a big PR for swiftsimio adding support for all of the numpy functions (already did ufuncs a while ago) supported by unyt, so as I work through each one individually I'm finding a few things ;) |
Incidentally, would be great to have a release of |
We're hoping to get unyt 3.0.4 out before 2025, though I can't make any promises. |
@neutrinoceros I don't know - if I find any more missing logic, then yes, but it's a matter of going through each function one at a time. |
I understand, I did go through the pain myself about 3 years ago and, not looking for excuses but I'm sure that trying to write ~300 functions in a short amount of time was at least part of the reason why so many of them have blatant bugs. |
The implementations of
linspace
andlogspace
are improved so thatretstep
can be used withlinspace
andlogspace
rejects inputs forstart
andstop
with non-dimensionless units, and also correctly handles thebase
keyword argument with units.Tests are updated to reflect changes.
Closes #542
Closes #543