BUG: fix a regression where np.linspace's num argument would be ignored for unyt_arrays
#553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for unyt_arrays
neutrinoceros
changed the title
unyt_arrays
|
Since the fix is so trivial (I really should have caught the bug in my review) and the bug affects downstream, I'll exceptionally self-merge for this one. |
neutrinoceros
changed the title
unyt_arraysnp.linspace's num argument would be ignored for unyt_arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression I overlooked when reviewing #544 but poped up in yt's test suite yt-project/yt#5091
for posterity: this regression never landed in a release.