Add media_support_internal to media_util gn target #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
added
cp-24.lts.1+
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4047 +/- ##
==========================================
- Coverage 57.67% 57.66% -0.02%
==========================================
Files 1746 1746
Lines 86295 86321 +26
==========================================
+ Hits 49771 49777 +6
- Misses 36524 36544 +20 ☔ View full report in Codecov by Sentry. |
jasonzhangxx
previously approved these changes
Aug 26, 2024
xiaomings
force-pushed
the
media_support_internal
branch
from
58c2793
to
4e36238
Compare
It was missing. It didn't cause any build issues as it's a header file. Also removed media_is_audio_supported.cc, media_is_supported.cc, and media_is_video_supported.cc from stub/BUILD.gn. They are not implementation Starboard interfaces (e.g. MediaIsAudioSupported() is internal interface, not exposed to Cobalt) and shouldn't be included in stub/BUILD.gn. b/361864042
xiaomings
force-pushed
the
media_support_internal
branch
from
4e36238
to
57e4f7b
Compare
jasonzhangxx
approved these changes
Aug 27, 2024
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
It was missing. It didn't cause any build issues as it's a header file. b/361864042 (cherry picked from commit 08cef06)
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
It was missing. It didn't cause any build issues as it's a header file. b/361864042 (cherry picked from commit 08cef06)
xiaomings
added a commit
that referenced
this pull request
Aug 27, 2024
…get (#4053) Refer to the original PR: #4047 It was missing. It didn't cause any build issues as it's a header file. Also removed media_is_audio_supported.cc, media_is_supported.cc, and media_is_video_supported.cc from stub/BUILD.gn. They are not implementing any Starboard interfaces (e.g. MediaIsAudioSupported() is internal interface, not exposed to Cobalt) and shouldn't be included in stub/BUILD.gn. b/361864042 --------- Co-authored-by: xiaomings <[email protected]>
xiaomings
added a commit
that referenced
this pull request
Aug 27, 2024
…get (#4054) Refer to the original PR: #4047 It was missing. It didn't cause any build issues as it's a header file. Also removed media_is_audio_supported.cc, media_is_supported.cc, and media_is_video_supported.cc from stub/BUILD.gn. They are not implementing any Starboard interfaces (e.g. MediaIsAudioSupported() is internal interface, not exposed to Cobalt) and shouldn't be included in stub/BUILD.gn. b/361864042 --------- Co-authored-by: xiaomings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was missing. It didn't cause any build issues as it's a header file.
Also removed media_is_audio_supported.cc, media_is_supported.cc, and media_is_video_supported.cc from stub/BUILD.gn. They are not implementing any Starboard interfaces (e.g. MediaIsAudioSupported() is internal interface, not exposed to Cobalt) and shouldn't be included in stub/BUILD.gn.
b/361864042