Cherry pick PR #4047: Add media_support_internal to media_util gn target #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was missing. It didn't cause any build issues as it's a header file. b/361864042 (cherry picked from commit 08cef06)
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-25.lts.1+-4047 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/10582711620 for details. |
xiaomings
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #4047
It was missing. It didn't cause any build issues as it's a header file.
Also removed media_is_audio_supported.cc, media_is_supported.cc, and media_is_video_supported.cc from stub/BUILD.gn. They are not implementing any Starboard interfaces (e.g. MediaIsAudioSupported() is internal interface, not exposed to Cobalt) and shouldn't be included in stub/BUILD.gn.
b/361864042