Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick PR #3989: Don't start DebugConsole with debug_console=off. #3996

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Cherry pick PR #3989: Don't start DebugConsole with debug_console=off. #3996

merged 2 commits into from
Aug 15, 2024

Commits on Aug 15, 2024

  1. Don't start DebugConsole with debug_console=off. (#3989) 

    When started with `--debug_console=off`, don't
start the DebugConsole at all.

Note: The web debugger (devtools) still works but
no longer will show overlay changes. To also
disable the web debugger, also start with
`--disable_web_debugger`.

b/205134049

(cherry picked from commit a9495fe)
    @jellefoks @anonymous1-me
    jellefoks authored and anonymous1-me committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d5f2c91 View commit details
    Browse the repository at this point in the history

  2. Update browser_module.cc 

    fix merge conflict.
    @jellefoks
    jellefoks authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    84d089c View commit details
    Browse the repository at this point in the history