Cherry pick PR #3989: Don't start DebugConsole with debug_console=off. #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When started with `--debug_console=off`, don't start the DebugConsole at all. Note: The web debugger (devtools) still works but no longer will show overlay changes. To also disable the web debugger, also start with `--disable_web_debugger`. b/205134049 (cherry picked from commit a9495fe)
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-24.lts.1+-3989 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/10398119782 for details. |
fix merge conflict.
jellefoks
approved these changes
Aug 15, 2024
|
I missed this from the cut / merge, have to wait until the builds are published. |
That's ok, this one is for 24.lts, and it's not for gold builds anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3989
When started with
--debug_console=off, don'tstart the DebugConsole at all.
Note: The web debugger (devtools) still works but
no longer will show overlay changes. To also
disable the web debugger, also start with
--disable_web_debugger.b/205134049