Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove InternalOpInfo #566

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Remove InternalOpInfo #566

merged 1 commit into from
Jul 11, 2023

Conversation

chacha912
Copy link
Contributor

@chacha912 chacha912 commented Jul 10, 2023 •
edited
Loading

What this PR does / why we need it?

The InternalOpInfo is unnecessary since we can get the path from the root.
This was referenced from the yorkie-team/yorkie-ios-sdk#78

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

hackerwins
hackerwins approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@hackerwins hackerwins merged commit 395d052 into main Jul 11, 2023
1 check passed
@hackerwins hackerwins deleted the cleanup-opinfo branch July 11, 2023 13:16
@chacha912 chacha912 mentioned this pull request Jul 12, 2023
Merged
2 tasks
hunkim98 pushed a commit to hunkim98/yorkie-js-sdk that referenced this pull request Jul 12, 2023
@chacha912 @hunkim98
Remove unnecessary InternalOpInfo (yorkie-team#566)
774ba27
@hackerwins hackerwins mentioned this pull request Sep 21, 2023
Merged
2 tasks
hackerwins added a commit that referenced this pull request Sep 21, 2023
@hackerwins
Remove unused trie (#651)
b86d963 
Trie was initially introduced to reduce the number of events from a
common ancestor(#351). However, it was later removed during the
implementation of the topic subscribe feature(#487, #566).

For now, I'll remove unused Trie and reopen the event-reducing issue
again(#266).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackerwins hackerwins Awaiting requested review from hackerwins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chacha912 @hackerwins