Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused trie #651

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Remove unused trie #651

merged 1 commit into from
Sep 21, 2023

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Sep 21, 2023

What this PR does / why we need it?

Remove unused trie

Trie was initially introduced to reduce the number of events from a common ancestor(#351). However, it was later removed during the implementation of the topic subscribe feature(#487, #566).

For now, I'll remove unused Trie and reopen the event-reducing issue again(#266).

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10% ⚠️

Comparison is base (52ffdbd) 88.88% compared to head (7c1e80b) 88.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   88.88%   88.78%   -0.10%     
==========================================
  Files          80       78       -2     
  Lines        8958     8899      -59     
  Branches      825      821       -4     
==========================================
- Hits         7962     7901      -61     
- Misses        688      691       +3     
+ Partials      308      307       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins merged commit b86d963 into main Sep 21, 2023
2 checks passed
@hackerwins hackerwins deleted the remove-trie branch September 21, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant