-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying a topic when subscribing to a document #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 55.54% 55.96% +0.41%
==========================================
Files 92 92
Lines 14303 14649 +346
==========================================
+ Hits 7945 8198 +253
- Misses 6358 6451 +93
|
humdrum
requested review from
7hong13,
chacha912 and
myupage
and removed request for
hackerwins
June 22, 2023 06:33
myupage
reviewed
Jun 26, 2023
chacha912
reviewed
Jul 10, 2023
Examples/TextEditorApp/TextEditorApp/TextEditor/TextViewModel.swift
Outdated
Show resolved
Hide resolved
2 tasks
* Replace Text.onChanges with Document.subscribe * hide TextChange class
myupage
approved these changes
Jul 11, 2023
chacha912
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #74 #76
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: