Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one wasm update workflow #246

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Use one wasm update workflow #246

merged 1 commit into from
Jun 20, 2024

Conversation

WilsonZiweiWang
Copy link
Contributor

Use stragegy.matrix property to run the job repeatedly with a list of variables

@WilsonZiweiWang WilsonZiweiWang self-assigned this Jun 19, 2024
deribaucourt
deribaucourt previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a test run before merging?

@WilsonZiweiWang WilsonZiweiWang force-pushed the use-one-update-wasm-yml-file branch 3 times, most recently from c86c679 to 2ce415e Compare June 20, 2024 14:40
@WilsonZiweiWang WilsonZiweiWang force-pushed the use-one-update-wasm-yml-file branch 3 times, most recently from 939e848 to 37e9489 Compare June 20, 2024 15:16
@deribaucourt deribaucourt mentioned this pull request Jun 20, 2024
Merged
@WilsonZiweiWang
Copy link
Contributor Author

Can you make a test run before merging?

Here is the run that shows 2 workflows were triggered. For testing purposes, I added on pull_request so it can trigger this new workflow when I push changes to this PR. However, workflows triggered this way can't create another pull request because Github restricts permissions assigned to GITHUB_TOKEN. So I couldn't demo them. There was no such problem because old workflows were triggered by the workflow_call which inherited the caller workflow's permissions, and the caller workflow was triggered by the scheduled event, which gave it full permissions.

@WilsonZiweiWang WilsonZiweiWang merged commit 1e414ff into yoctoproject:staging Jun 20, 2024
5 checks passed
@WilsonZiweiWang WilsonZiweiWang deleted the use-one-update-wasm-yml-file branch June 20, 2024 15:29
@deribaucourt
Copy link
Member

Can you make a test run before merging?

Here is the run that shows 2 workflows were triggered. For testing purposes, I added on pull_request so it can trigger this new workflow when I push changes to this PR. However, workflows triggered this way can't create another pull request because Github restricts permissions assigned to GITHUB_TOKEN. So I couldn't demo them. There was no such problem because old workflows were triggered by the workflow_call which inherited the caller workflow's permissions, and the caller workflow was triggered by the scheduled event, which gave it full permissions.

GITHUB_TOKEN issues are expected when running on PRs instead of staging/main branch. Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deribaucourt deribaucourt deribaucourt approved these changes

@idillon-sfl idillon-sfl Awaiting requested review from idillon-sfl

Assignees

@WilsonZiweiWang WilsonZiweiWang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilsonZiweiWang @deribaucourt