Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove wasm files from repo #243

Conversation

idillon-sfl
Copy link
Member

No description provided.

Copy link
Contributor

@WilsonZiweiWang WilsonZiweiWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it would be better to have the new process documented.

Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe update documentation in the developper's README as suggested by Ziwei

README-DEVELOPER.md Outdated Show resolved Hide resolved
@idillon-sfl idillon-sfl force-pushed the Feature-14857-Remove-wasm-files-from-repo branch from e30685f to 2445060 Compare June 20, 2024 18:11
README-DEVELOPER.md Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@idillon-sfl idillon-sfl force-pushed the Feature-14857-Remove-wasm-files-from-repo branch from 2445060 to a6add43 Compare June 21, 2024 17:45
@idillon-sfl idillon-sfl force-pushed the Feature-14857-Remove-wasm-files-from-repo branch from a6add43 to ad5142f Compare June 21, 2024 17:58
README-DEVELOPER.md Outdated Show resolved Hide resolved
@idillon-sfl
Copy link
Member Author

I changed "build:wasm" to "fetch:wasm". I'm thinking this is not a useful distinction.

@idillon-sfl idillon-sfl force-pushed the Feature-14857-Remove-wasm-files-from-repo branch from 98c125d to 54bb8a3 Compare June 25, 2024 14:31
@idillon-sfl idillon-sfl merged commit 9c5160e into yoctoproject:staging Jun 28, 2024
5 checks passed
@idillon-sfl idillon-sfl deleted the Feature-14857-Remove-wasm-files-from-repo branch June 28, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants