Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when used objects with PK in ArrayColumn #141

Merged
merged 3 commits into from
Nov 27, 2023

replace PHP_EOL to \n

81f2baf
Select commit
Loading
Failed to load commit list.
Merged

Fix error when used objects with PK in ArrayColumn #141

replace PHP_EOL to \n
81f2baf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 27, 2023 in 0s

92.09% (-0.11%) compared to 0c25a7f

View this Pull Request on Codecov

92.09% (-0.11%) compared to 0c25a7f

Details

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0c25a7f) 92.20% compared to head (81f2baf) 92.09%.

Files Patch % Lines
src/BaseListView.php 61.53% 5 Missing ⚠️
src/Column/DataColumnRenderer.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
- Coverage     92.20%   92.09%   -0.11%     
- Complexity      458      461       +3     
============================================
  Files            27       27              
  Lines          1616     1620       +4     
============================================
+ Hits           1490     1492       +2     
- Misses          126      128       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.