Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when used objects with PK in ArrayColumn #141

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Fix error when used objects with PK in ArrayColumn #141

merged 3 commits into from
Nov 27, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 27, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #140

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0c25a7f) 92.20% compared to head (81f2baf) 92.09%.

Files Patch % Lines
src/BaseListView.php 61.53% 5 Missing ⚠️
src/Column/DataColumnRenderer.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
- Coverage     92.20%   92.09%   -0.11%     
- Complexity      458      461       +3     
============================================
  Files            27       27              
  Lines          1616     1620       +4     
============================================
+ Hits           1490     1492       +2     
- Misses          126      128       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 27, 2023

PR Summary

  • Improved Compatibility with Keyset Paginator
    The renderLinkSorter method in both BaseListView.php and DataColumnRenderer.php have been modified to handle the KeysetPaginator class. This allows for better seamless integration with more complex pagination systems.

  • Adapting renderSummary with Offset Paginator
    The renderSummary method in BaseListView.php was updated to use the getDataReader method and support the OffsetPaginator class. This change greatly enhances our list view's ability to display large data sets efficiently and manageably.

  • Handle Object-based Primary Keys
    Both the createUrl method in ActionColumnRenderer.php and a test case in ActionColumnTest.php were updated to handle cases where the primary key is an object. This helps to ensure the smooth processing of items with non-standard primary keys in our data handling.

@vjik vjik merged commit 6f023de into master Nov 27, 2023
19 of 22 checks passed
@vjik vjik deleted the fix-pk-bug branch November 27, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants