fix: orientation on iOS16

[gramiro]

I've modified Orientation.m according to what Apple is requiring on iOS16 since [[UIDevice currentDevice] setValue:forKey:]; appears to be buggy.

Notice that the changes are under a condition of the OS being iOS16.

[QSuraj]

We also need to update unlockAllOrientations to -

RCT_EXPORT_METHOD(unlockAllOrientations)
{
  #if DEBUG
    NSLog(@"Unlock All Orientations");
  #endif
  UIDeviceOrientation orientation = [[UIDevice currentDevice] orientation];
  [Orientation setOrientation:UIInterfaceOrientationMaskAllButUpsideDown];
  [self lockToOrientationWithMask:UIInterfaceOrientationMaskAllButUpsideDown interfaceOrientation:UIInterfaceOrientationMaskAllButUpsideDown deviceOrientation:orientation];
}

[yvan33]

@gramiro - Any update?

[codal-mpawar]

hey, guys please update ASAP. we are stuck here for the build.

[gramiro]

hi guys, sorry, been a while. @QSuraj I didn't include this since it was not in the original library

[NeerajNema1988]

Other than iOS 16, Builds are failing.

[codal-mpawar]

Other than iOS 16, Builds are failing.

same issue for me iOS builds are failling.

[nicolas6422]

Fixed failing build by wrapping ios 16 code with #ifdef __IPHONE_16_0

Here's a patch file I made if you're using patch-package

https://gist.github.com/nicolas6422/80cbc4528b4d4798c53ffdd2f56c3625

[kesha-antonov]

Fixed failing build by wrapping ios 16 code with #ifdef __IPHONE_16_0

Here's a patch file I made if you're using patch-package

https://gist.github.com/nicolas6422/80cbc4528b4d4798c53ffdd2f56c3625

works on ios 16

[gramiro]

@nicolas6422 do you know if that's future proof? Like next year's iOS 17?

[nicolas6422]

@gramiro yes, __IPHONE_16_0 will always be defined after for Xcode >= 14

[codal-mpawar]

@gramiro @nicolas6422 any update for release mode because its not working for release mode.

[brycnguyen]

Seeing the same issue that this doesn't work in release mode

[ubdorji]

@codal-mpawar ran into a similar issue, for us we build our app with eas so it was about setting the image property of ios to latest in our eas.json file so that our app was built with the latest Xcode 14.1 sdk.

[codal-mpawar]

@gramiro If you have a solution can you please fork the library and try to resolve this if possible? it will great help for us.

[LuczDev]

seems the camera screen is also orientated, is any way to fix?

[swaroopaillinda]

hii as any one found solution I am also facing issue related to orientation locktolandscape not working

Please @LuczDev if you found any solution please respond asap thanks

[Yandamuri]

@gramiro If you have a solution can you please fork the library and try to resolve this if possible? it will great help for us.

Did you find solution for release mode?