Orintentation problems with iOS16

[Girum]

Hi! After update to iOS16, some functionallities dont work sometimes. The package will be updated?

[nartco]

Up,same issue

[bishalfan]

+1

[Girum]

I changed to react-native-orientation-locker and it works fine! But now android has a problem: I'm using react-native-video lib. When I change the orientation, or even change something, the video reloads

[minhpham1203]

I changed to react-native-orientation-locker and it works fine! But now android has a problem: I'm using react-native-video lib. When I change the orientation, or even change something, the video reloads
Hi @Girum , I am using react-native-orientation-locker, but the callback function is not called in addOrientationListener. So I can not check the orientation. Any solution? Thank you!

[Girum]

Hi @minhpham1203 . HEre works perfectly.

Orientation.addOrientationListener(orientationChange)
        
return () => {
  Orientation.removeOrientationListener(orientationChange)
};

const orientationChange = (orientation) => {
        if(orientation == 'LANDSCAPE-RIGHT' || orientation ==  'LANDSCAPE-LEFT') {
           ...

            
        } else if (orientation == 'PORTRAIT') {
            ...
        }
    }

The only change I made is that dont exists the enum "LANDASCAPE". I had to set the conditions to "LANDASCAPE_LEFT" and "LANDASCAPE_RIGHT"

@minhpham1203 afeter another test, it not works too... =(. We have to ask in the react-native-orientation-locker github

It fires the if(orientation == 'LANDSCAPE-RIGHT' || orientation == 'LANDSCAPE-LEFT'), but not work in another functions inside of this if

[gramiro]

Hey guys, here's a PR with a fix for iOS16 orientation :)

[vinceplusplus]

if you are still building with iOS 15 sdk, could try going into Orientation.m, and add

[UIViewController attemptRotationToDeviceOrientation];

below every

[[UIDevice currentDevice] setValue:[NSNumber numberWithInteger: ... ] forKey:@"orientation"];

that should work on iOS 16

[veerabhadrasajjan]

Hey guys, here's a PR with a fix for iOS16 orientation :)

The package will be updated?

[codal-mpawar]

Hey guys, here's a PR with a fix for iOS16 orientation :)

any update on this? @gramiro @vinceplusplus @Girum @veerabhadrasajjan

[kesha-antonov]

I think we need to take ownership of this package or use some stable fork since this lib wasn't updated for 5 years. I think it's unlikely it'll be updated in the future

[gramiro]

@codal-mpawar I'm not the owner of the library so I guess we need to do what @kesha-antonov is proposing. As a temporary solution I'm just patching my projects.

[codal-mpawar]

@gramiro it's working locally but it's not working on the release mode.

below is patch package.
diff --git a/node_modules/react-native-orientation/iOS/RCTOrientation/Orientation.m b/node_modules/react-native-orientation/iOS/RCTOrientation/Orientation.m
index 15e9927..67940a4 100644
--- a/node_modules/react-native-orientation/iOS/RCTOrientation/Orientation.m
+++ b/node_modules/react-native-orientation/iOS/RCTOrientation/Orientation.m
@@ -39,15 +39,38 @@ + (BOOL)requiresMainQueueSetup
return YES;
}

+- (void)dispatchOrientationChangeEvent:(UIDeviceOrientation)orientation {

• [self.bridge.eventDispatcher sendDeviceEventWithName:@"specificOrientationDidChange"

•                                            body:@{@"specificOrientation": [self getSpecificOrientationStr:orientation]}];
  

• [self.bridge.eventDispatcher sendDeviceEventWithName:@"orientationDidChange"

•                                            body:@{@"orientation": [self getOrientationStr:orientation]}];
  

+}
+
+- (void)lockToOrientationWithMask:(UIInterfaceOrientationMask)maskOrientation interfaceOrientation:(UIInterfaceOrientation)interfaceOrientation deviceOrientation:(UIDeviceOrientation)deviceOrientation {

• if (@available(iOS 16, *)) {
  +#ifdef __IPHONE_16_0

•    dispatch_sync(dispatch_get_main_queue(), ^{
  

•        NSArray *array = [[[UIApplication sharedApplication] connectedScenes] allObjects];
  

•        UIWindowScene *scene = (UIWindowScene *)array[0];
  

•        [UIViewController attemptRotationToDeviceOrientation];
  

•        UIWindowSceneGeometryPreferencesIOS *geometryPreferences = [[UIWindowSceneGeometryPreferencesIOS alloc] initWithInterfaceOrientations:maskOrientation];
  

•        [scene requestGeometryUpdateWithPreferences:geometryPreferences errorHandler:^(NSError * _Nonnull error) {}];
  

•    });
  

•    [self dispatchOrientationChangeEvent:deviceOrientation];
  

+#endif

• } else {

•    [[NSOperationQueue mainQueue] addOperationWithBlock:^ {
  

•        [[UIDevice currentDevice] beginGeneratingDeviceOrientationNotifications];
  

•        [[UIDevice currentDevice] setValue:[NSNumber numberWithInteger:interfaceOrientation] forKey:@"orientation"];
  

•    }];
  

• }
  +}

• (void)deviceOrientationDidChange:(NSNotification *)notification
  {
• UIDeviceOrientation orientation = [[UIDevice currentDevice] orientation];
• [self.bridge.eventDispatcher sendDeviceEventWithName:@"specificOrientationDidChange"

•                                          body:@{@"specificOrientation": [self getSpecificOrientationStr:orientation]}];
  

• [self.bridge.eventDispatcher sendDeviceEventWithName:@"orientationDidChange"

•                                          body:@{@"orientation": [self getOrientationStr:orientation]}];
  

• UIDeviceOrientation orientation = [[UIDevice currentDevice] orientation];
• [self dispatchOrientationChangeEvent:orientation];
  }

• (NSString *)getOrientationStr: (UIDeviceOrientation)orientation {
  @@ -156,12 +179,8 @@ - (NSString *)getSpecificOrientationStr: (UIDeviceOrientation)orientation {
  #if DEBUG
  NSLog(@"Locked to Portrait");
  #endif
• [Orientation setOrientation:UIInterfaceOrientationMaskPortrait];
• [[NSOperationQueue mainQueue] addOperationWithBlock:^ {
• [[UIDevice currentDevice] beginGeneratingDeviceOrientationNotifications];
• [[UIDevice currentDevice] setValue:[NSNumber numberWithInteger: UIInterfaceOrientationPortrait] forKey:@"orientation"];
• }];

• [Orientation setOrientation:UIInterfaceOrientationMaskPortrait];
• [self lockToOrientationWithMask:UIInterfaceOrientationMaskPortrait interfaceOrientation:UIInterfaceOrientationPortrait deviceOrientation:UIDeviceOrientationPortrait];
  }

RCT_EXPORT_METHOD(lockToLandscape)
@@ -172,17 +191,11 @@ - (NSString *)getSpecificOrientationStr: (UIDeviceOrientation)orientation {
UIDeviceOrientation orientation = [[UIDevice currentDevice] orientation];
NSString *orientationStr = [self getSpecificOrientationStr:orientation];
if ([orientationStr isEqualToString:@"LANDSCAPE-LEFT"]) {

• [Orientation setOrientation:UIInterfaceOrientationMaskLandscape];
• [[NSOperationQueue mainQueue] addOperationWithBlock:^ {

•  [[UIDevice currentDevice] beginGeneratingDeviceOrientationNotifications];
  

•  [[UIDevice currentDevice] setValue:[NSNumber numberWithInteger: UIInterfaceOrientationLandscapeRight] forKey:@"orientation"];
  

• }];

•  [Orientation setOrientation:UIInterfaceOrientationMaskLandscapeRight];
  

•  [self lockToOrientationWithMask:UIInterfaceOrientationMaskLandscapeRight interfaceOrientation:UIInterfaceOrientationLandscapeRight deviceOrientation:UIDeviceOrientationLandscapeRight];
  

  } else {

• [Orientation setOrientation:UIInterfaceOrientationMaskLandscape];
• [[NSOperationQueue mainQueue] addOperationWithBlock:^ {

•  [[UIDevice currentDevice] beginGeneratingDeviceOrientationNotifications];
  

•  [[UIDevice currentDevice] setValue:[NSNumber numberWithInteger: UIInterfaceOrientationLandscapeLeft] forKey:@"orientation"];
  

• }];

•  [Orientation setOrientation:UIInterfaceOrientationMaskLandscapeLeft];
  

•  [self lockToOrientationWithMask:UIInterfaceOrientationMaskLandscapeLeft interfaceOrientation:UIInterfaceOrientationLandscapeLeft deviceOrientation:UIDeviceOrientationLandscapeLeft];
  

  }
  }

@@ -192,11 +205,7 @@ - (NSString *)getSpecificOrientationStr: (UIDeviceOrientation)orientation {
NSLog(@"Locked to Landscape Left");
#endif
[Orientation setOrientation:UIInterfaceOrientationMaskLandscapeLeft];

• [[NSOperationQueue mainQueue] addOperationWithBlock:^ {

•    [[UIDevice currentDevice] beginGeneratingDeviceOrientationNotifications];
  

•    [[UIDevice currentDevice] setValue:[NSNumber numberWithInteger: UIInterfaceOrientationLandscapeLeft] forKey:@"orientation"];
  

• }];

• [self lockToOrientationWithMask:UIInterfaceOrientationMaskLandscapeLeft interfaceOrientation:UIInterfaceOrientationLandscapeLeft deviceOrientation:UIDeviceOrientationLandscapeLeft];
  }

RCT_EXPORT_METHOD(lockToLandscapeRight)
@@ -204,13 +213,8 @@ - (NSString *)getSpecificOrientationStr: (UIDeviceOrientation)orientation {
#if DEBUG
NSLog(@"Locked to Landscape Right");
#endif

• [Orientation setOrientation:UIInterfaceOrientationMaskLandscapeRight];
• [[NSOperationQueue mainQueue] addOperationWithBlock:^ {
• // this seems counter intuitive
• [[UIDevice currentDevice] beginGeneratingDeviceOrientationNotifications];
• [[UIDevice currentDevice] setValue:[NSNumber numberWithInteger: UIInterfaceOrientationLandscapeRight] forKey:@"orientation"];
• }];

• [Orientation setOrientation:UIInterfaceOrientationMaskLandscapeRight];
• [self lockToOrientationWithMask:UIInterfaceOrientationMaskLandscapeRight interfaceOrientation:UIInterfaceOrientationLandscapeRight deviceOrientation:UIDeviceOrientationLandscapeRight];
  }

RCT_EXPORT_METHOD(unlockAllOrientations)
@@ -218,9 +222,9 @@ - (NSString *)getSpecificOrientationStr: (UIDeviceOrientation)orientation {
#if DEBUG
NSLog(@"Unlock All Orientations");
#endif

• UIDeviceOrientation orientation = [[UIDevice currentDevice] orientation];
  [Orientation setOrientation:UIInterfaceOrientationMaskAllButUpsideDown];
  -// AppDelegate *delegate = (AppDelegate *)[[UIApplication sharedApplication] delegate];
  -// delegate.orientation = 3;
• [self lockToOrientationWithMask:UIInterfaceOrientationMaskAllButUpsideDown interfaceOrientation:UIInterfaceOrientationMaskAllButUpsideDown deviceOrientation:orientation];
  }

• (NSDictionary *)constantsToExport

[pawansharmaAccolite]

if you are still building with iOS 15 sdk, could try going into Orientation.m, and add

[UIViewController attemptRotationToDeviceOrientation];

below every

[[UIDevice currentDevice] setValue:[NSNumber numberWithInteger: ... ] forKey:@"orientation"];

that should work on iOS 16

can you confirm that is working in real device not in simulator

[vinceplusplus]

@pawansharmaAccolite, yes, it is

[pawansharmaAccolite]

yes same here i made this patch its working fine at local but when i hit on pipeline its not working