Skip to content

Adds at-rule handling to CSS compression. #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds at-rule handling to CSS compression. #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion minify/CSS/Compressor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,42 @@ protected function _process($css)

// prevent triggering IE6 bug: http://www.crankygeek.com/ie6pebug/
$css = preg_replace('/:first-l(etter|ine)\\{/', ':first-l$1 {', $css);


// handle @ rules
$at_rules = '';

// @charset rules are only valid as the first line in a css file
if( preg_match_all('/@charset[^;]*;/i', $css, $charsets) ) {
$charsets = $charsets[0];
$charsets = array_unique($charsets);
$charset = $charsets[0];
if( count($charsets) > 1 ) {
// use most common @charset rule
$charsets = array_count_values($charsets);
$charset = array_search(max($charsets), $charsets);
}
$at_rules .= "$charset\n";
$css = preg_replace('/@charset[^;]*;/i', '', $css);
}

// @namespace are only valid before all other rules except @charset
if( preg_match_all('/(@namespace[^;]*;)/i', $css, $namespaces) ) {
$namespaces = $namespaces[0];
$namespaces = array_unique($namespaces);
$at_rules .= implode("\n", $namespaces);
$css = preg_replace('/(@namespace[^;]*;)/i', '', $css);
}

/*
* TODO: Actually include css url's content referenced and remove the @import rules.
* They are only valid before all block rules and context needs to be maintained.
*/
// remove all @import rules
$css = preg_replace('/@import[^;]*;/i', '', $css);

// prepend at rules to css
$css = $at_rules . $css;

return trim($css);
}

Expand Down