Adds at-rule handling to CSS compression. #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue #59. |
|
@msigley this Can you instead open a PR to apply the change to the file in that project, and we can fold it into Dependency Minification. I wouldn't want the changes to get lost the next time it gets updated. |
|
Thanks I submitted a new pull request to the Minify project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handles charset, namespace, and import at-rules according to:
https://developer.mozilla.org/en-US/docs/Web/CSS/At-rule
Import rules are currently just stripped out of the CSS to prevent issues in the output, but this could be improved by including the contents of the import url and compressing it.