336 fix spark badge display #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added SparkModel import to App.js for improved Spark session handling. - Refactored handleExistingNotebookClick to use async/await for fetching notebook data and Spark application details concurrently. - Implemented error handling for fetching notebook and Spark app, ensuring better user feedback and session management. - Introduced a new method in SparkModel.js to retrieve Spark app details by notebook path, enhancing integration with the backend API.
…ling - Added useRef for notebook reference to facilitate direct interaction with the Notebook component. - Updated Spark app ID handling to ensure it is set correctly when an active Spark application is detected. - Minor refactoring for improved clarity and maintainability of the code.
…egration - Added console log to display the associated Spark application after fetching notebook data. - Improved visibility into the notebook and Spark app interaction for better debugging and user feedback.
…app ID setter - Updated Notebook.js to use forwardRef, allowing parent components to directly interact with the Notebook's internal state. - Implemented useImperativeHandle to expose a method for setting the Spark app ID, enhancing integration with parent components. - Improved code clarity and maintainability by restructuring the component's function signature.
- Added useEffect in App.js to log the current notebook reference, aiding in tracking its state. - Implemented useEffect in Notebook.js to log changes to sparkAppId, enhancing visibility into Spark application interactions. - Updated setSparkAppId method in Notebook.js to include logging when setting the Spark app ID, improving traceability during state changes.
…agement - Updated the Notebook component to reset sparkAppId when switching notebooks and immediately fetch the associated Spark app. - Improved error handling during the Spark app fetch process, logging any failures for better debugging. - Streamlined the useEffect hook to ensure proper state management and clarity in the notebook's functionality.
…termination cell - Changed the execution state of an existing code cell from true to false, indicating it was not executed. - Added a new code cell to the demo notebook for stopping the Spark session, including execution metadata and success status. - Enhanced the notebook structure for better clarity and usability in Spark session management.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.