Refactor Docker options and command in integration-test.yml

xuwenyihust · Jul 3, 2024 · dad4464 · dad4464
1 parent 082e6d6
commit dad4464
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml
@@ -29,8 +29,8 @@ jobs:
           --health-timeout 5s
           --health-retries 5
           --publish 8888:8888
-          --command "jupyter notebook --ip='0.0.0.0' --port=8888 --no-browser --allow-root --NotebookApp.token='' --NotebookApp.password=''"
-
+        
+        
     steps:
       - name: Checkout code
         uses: actions/checkout@v2

diff --git a/docker-compose.yaml b/docker-compose.yaml
@@ -37,7 +37,7 @@ services:
       - JUPYTER_ENABLE_LAB=no
       - ENVIRONMENT=development
       - PYSPARK_SUBMIT_ARGS=--packages io.delta:delta-spark_2.12:3.0.0 --conf spark.sql.extensions=io.delta.sql.DeltaSparkSessionExtension --conf spark.sql.catalog.spark_catalog=org.apache.spark.sql.delta.catalog.DeltaCatalog pyspark-shell
-    command: ["jupyter", "notebook", "--ip='0.0.0.0'", "--port=8888", "--no-browser", "--allow-root", "--NotebookApp.token=''", "--NotebookApp.password=''"]
+    # command: ["jupyter", "notebook", "--ip='0.0.0.0'", "--port=8888", "--no-browser", "--allow-root", "--NotebookApp.token=''", "--NotebookApp.password=''"]
     volumes:
       - ./data/spark-events:/opt/data/spark-events
       - ./data/spark-warehouse:/opt/data/spark-warehouse