Enable out-of-range group action configuration using keymap flags (take 2) #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
enhancement
wismill
force-pushed
the
keymap/out-of-range-group-action2
branch
3 times, most recently
from
dab9612
to
16e9649
Compare
This was referenced Sep 18, 2024
wismill
added
the
X11 legacy: missing feature
|
Missing: get and use the corresponding control value from X11 for libxbbcommon-x11. |
2 tasks
Introduce 2 new keymap compilation flags to configure the action: - `XKB_KEYMAP_REDIRECT_OUT_OF_RANGE_LAYOUT` to use “redirect into range”. - `XKB_KEYMAP_CLAMP_OUT_OF_RANGE_LAYOUT` to use “clamp into range”. The default action remains “wrap into range” using integer modulus.
wismill
force-pushed
the
keymap/out-of-range-group-action2
branch
from
16e9649
to
f7563b6
Compare
|
The issue with the current implementation is that we are using flag positions to encode the target layout number, but with #515 coming this will not scale. We could keep the flag, but add a new function to change the target layout (default: 0). A use case for having target layout different of 0 is tweaking the shortcuts (Ctrl, Alt, etc.) to change the group, in order to make e.g. non Latin layout work without relying on the toolkit to look for Latin letter in other layouts. This would most likely require #487. |
wismill
changed the title
3 tasks
|
Closing in favor of #516. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #487 I added keymap compile flags to configure the out-of-range group action, but it should be separate PR.
Note that I proposed #488 previously but @bluetech advised to keep
xkb_keymap“immutable”.