Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable out-of-range group action configuration #488

Closed

Conversation

wismill
Copy link
Member

@wismill wismill commented Jul 12, 2024

In #487 I added keymap compile flags to configure the out-of-range group action, but it should be separate PR. Now I am also not sure the flags are the best API for this, so I added the following:

  • xkb_keymap_set_out_of_range_layout_redirect
  • xkb_keymap_set_out_of_range_layout_clamp

I have not added a function for the wrap action because it is the default, but we may need it for completion.

Another question is if it’s better to add only one function and expose xkb_range_exceed_type?

TODO:

  • Changelog entry

@wismill wismill marked this pull request as ready for review July 12, 2024 02:45
@wismill wismill added the X11 legacy: missing feature Indicates a need to implement legacy X11 features label Jul 12, 2024
@bluetech
Copy link
Member

bluetech commented Sep 8, 2024

I haven't looked into the actual details, but just a general comment -- up to now xkb_keymap is an immutable type (well, at least except for the refcnt), which I think is a nice and useful property. Therefore I think it would be preferable if these settings were specified on keymap creation rather than after the fact.

@wismill
Copy link
Member Author

wismill commented Sep 18, 2024

Closing in favor of #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X11 legacy: missing feature Indicates a need to implement legacy X11 features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants