-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor site search to use custom element #218
Conversation
650dfdc
to
870dc31
Compare
4b547bd
to
6618726
Compare
6618726
to
72a927a
Compare
72a927a
to
791bed6
Compare
@paulrobertlloyd i know this has been merged now, but did you consider using the new |
The Custom elements are sooooo brilliant, though. I’m 1000% sold on them, and have basically added them to everything. 😎 |
@paulrobertlloyd I must admit I’ve not looked into them properly yet. Instinctively I shudder at the memory of the bad old days of browser wars and proprietary tags, but maybe the JavaScript API makes these more sensible. |
It’s basically Like all tools, custom elements can be used for good or evil, but the current interest in what are being dubbed ‘HTML Web Components’ means that they basically make progressive enhancement an attractive proposition. This is a good place to get started: https://gomakethings.com/the-elevator-pitch-for-web-components/ |
(Meanwhile, I’ve broken the site at 11:30pm… 🙄) |
The JavaScript for the site search is a bit of a relic, so updated so that:
Class
Fetch
API overXMLHttpRequest