Upgrade to govuk-frontend v5
#214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrobertlloyd
added
documentation
paulrobertlloyd
commented
Dec 8, 2023
| @@ -28,7 +28,7 @@ module.exports = (eleventyConfig) => { | |||
|
|
|||
| const searchPaths = [ | |||
| './node_modules/@x-govuk/govuk-eleventy-plugin', | |||
| resolveNpmModule('govuk-frontend'), | |||
| './node_modules/govuk-frontend/dist', | |||
There was a problem hiding this comment.
This removes the use of resolveModule as not quite sure how I can make this work with a sub-directory.
paulrobertlloyd
force-pushed
the
govuk-frontend-5
branch
2 times, most recently
from
edf819b to
168738b
Compare
paulrobertlloyd
force-pushed
the
govuk-frontend-5
branch
from
168738b to
a144c0f
Compare
paulrobertlloyd
force-pushed
the
govuk-frontend-5
branch
from
a144c0f to
5ad5017
Compare
paulrobertlloyd
force-pushed
the
govuk-frontend-5
branch
from
5ad5017 to
733c908
Compare
paulrobertlloyd
force-pushed
the
govuk-frontend-5
branch
from
733c908 to
621886d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Upgrades the plugin to use
govuk-frontendv5. This requires the following changes:eleventyConfig.addPassthroughCopyto copy assets from thedistsubfolderdistfolder$govuk-new-link-styles: true;settingdistfolderUpdating the base template to change how JavaScript support classes are addedChanging the header logotype
Currently, you can set
header.organisationLogo(replaces the crown with one of 3 options:royal-arms,x-govukorfalse) andheader.organisationName(replaces GOV.UK text).Version 5 of
govuk-frontendcombines both the logo and logotype into one image meaning a new approach is needed. This is my proposal:header.logotypefalseheader.logotypex-govukheader.logotype.textDoSACheader.logotype.html<mark>Do<em>SAC</em></mark>This means a textual logo can be used in place of ‘GOV.UK’ without need for creating an SVG image, but one can be supplied via the HTML option.