-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve authentication name validation. #6288
Improve authentication name validation. #6288
Conversation
956d679
to
5bbf343
Compare
5bbf343
to
45dfd44
Compare
PR builder started |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6288 +/- ##
============================================
+ Coverage 45.91% 46.20% +0.28%
+ Complexity 14481 14454 -27
============================================
Files 1672 1672
Lines 103141 102230 -911
Branches 18010 17876 -134
============================================
- Hits 47360 47238 -122
+ Misses 48970 48220 -750
+ Partials 6811 6772 -39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder completed |
PR builder started |
1066f2a
to
67dbed1
Compare
...c/main/java/org/wso2/carbon/identity/application/common/ApplicationAuthenticatorService.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/carbon/identity/application/common/dao/AuthenticatorManagementDAO.java
Outdated
Show resolved
Hide resolved
.../java/org/wso2/carbon/identity/application/common/util/AuthenticatorMgtExceptionBuilder.java
Outdated
Show resolved
Hide resolved
...org/wso2/carbon/identity/application/common/util/UserDefinedLocalAuthenticatorValidator.java
Outdated
Show resolved
Hide resolved
.../wso2/carbon/identity/application/common/model/test/ApplicationAuthenticatorServiceTest.java
Show resolved
Hide resolved
...cation.mgt.ui/src/main/java/org/wso2/carbon/identity/application/mgt/ui/ApplicationBean.java
Outdated
Show resolved
Hide resolved
...g.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/util/IdPManagementConstants.java
Outdated
Show resolved
Hide resolved
PR builder completed |
.../java/org/wso2/carbon/identity/application/common/constant/AuthenticatorMgtSQLConstants.java
Outdated
Show resolved
Hide resolved
...t/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/IdentityProviderManager.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
PR builder started |
PR builder completed |
The failing integration tests are due to error messages changes, with the wso2/product-is#22265 they will be addressed. |
Issue:
Following improvements need to be done to the custom authentication management.
Currently, for user-defined authenticators, it is checking for any conflict with system-defined names making authenticator name unique.
The reqirement is to have unique identifier for the amr values. However, with the implementation so far, if a custom authenticator is created with the name whatsappAuthenticator and we later introduce a system authenticator with the same name, it would result in a conflict. There improve authenticator name regex validation to check whether authenticator name start with
custom-
prefix with atleast three charactors.