Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update user defined authenticator name in integration tests. #22260

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Update user defined authenticator name in integration tests. #22260

merged 1 commit into from
Jan 19, 2025
+5 −5

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Jan 16, 2025 •
edited
Loading

Issue:

With the PR [1], following changes are added. This PR to improve integration tests for new validations.

  1. There improve authenticator name regex validation to check whether authenticator name start with custom- prefix with atleast three charactors.
  2. In addtion to above validate authenticator name uniqueness across both local and federared authenticator names.
  3. Improve display name validation to check whether it has atleast three charactors.

[1]. wso2/carbon-identity-framework#6288

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12805337145

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12805337145
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the update-user-defined-auth-mgt-tests branch from 5a408e5 to 367abff Compare January 16, 2025 11:20
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12813776540

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12813776540
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12813776540

@Thisara-Welmilla Thisara-Welmilla merged commit c2d4e9b into wso2:master Jan 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashanthamara ashanthamara ashanthamara approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thisara-Welmilla @jenkins-is-staging @ashanthamara