-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop signatures for public key fields where not needed. #187
Conversation
c1ecea1
to
e3e7f27
Compare
This is a follow-up to #185. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SanjayVas)
src/main/proto/wfa/measurement/api/v2alpha/measurement.proto
line 78 at r1 (raw file):
// (-- // TODO(world-federation-of-advertisers/cross-media-measurement-api#188): // Remove this once the certificate is always specified in
you can remove this if you wait for PR 171 to merge first. wdyt?
src/main/proto/wfa/measurement/api/v2alpha/requisition.proto
line 84 at r1 (raw file):
// Remove this once the certificate is always specified in // `FulfillDirectRequisitionRequest`. --) string data_provider_certificate = 6 [
ditto
e3e7f27
to
92e2912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @stevenwarejones)
src/main/proto/wfa/measurement/api/v2alpha/measurement.proto
line 78 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
you can remove this if you wait for PR 171 to merge first. wdyt?
Not quite. The always part here is important, meaning all EDPs need to be specifying the new field.
src/main/proto/wfa/measurement/api/v2alpha/requisition.proto
line 84 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
ditto
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
92e2912
to
9ae62d6
Compare
This is a breaking API change, but attempts to maintain wire-compatibility for EDP Requisition fulfillment.
9ae62d6
to
ecdc4b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
This is a breaking API change, but attempts to maintain wire-compatibility for EDP Requisition fulfillment.